Closed
Conversation
Owner
|
Thanks! Let me try out something different, as I mentioned in #32. I think your simple fix would work, but be a "band-aid" over a problem that I created in the architecture. |
Owner
|
Thanks again for contributing and pointing out the issue! I'll be closing this PR, because it only contains a "quick fix" and I wanted to cleanup the underlying confusion in the code, which was more work, but should make the project easier to understand in the future: Feel free to add feedback on my PR, if you have any, otherwise I'll merge it soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#32
This is fix for Windows, I'm not sure if this problem occurs on Linux or Mac